Skip to content

[PR] Fix AIX build break#3946

Closed
KamathForAIX wants to merge 1 commit intofacebookresearch:mainfrom
KamathForAIX:main
Closed

[PR] Fix AIX build break#3946
KamathForAIX wants to merge 1 commit intofacebookresearch:mainfrom
KamathForAIX:main

Conversation

@KamathForAIX
Copy link
Contributor

Closes #3945

@alexanderguzhva
Copy link
Contributor

lgtm, the change totally makes sense

@kuarora kuarora mentioned this pull request Oct 14, 2024
2 tasks
@facebook-github-bot
Copy link
Contributor

@kuarora has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kuarora kuarora changed the title Fix AIX build break [PR] Fix AIX build break Oct 14, 2024
@kuarora kuarora added the ignore label Oct 14, 2024
@mnorris11 mnorris11 removed the ignore label Oct 14, 2024
@mnorris11
Copy link
Contributor

We reverted the external module change already in #3954, so closing the PR.

If/when we re-add it, we will incorporate this logic.

@mnorris11 mnorris11 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAISS build break in AIX (PowerPC)

5 participants