Skip to content

Adding missing includes which are necessary for building. #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mfixman wants to merge 3 commits into from
Closed

Adding missing includes which are necessary for building. #3533

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa04b63
Adding missing includes which are necessary for building.
mfixman Jun 21, 2024
c8579c6
Merge branch 'main' into fix-missing-imports
junjieqi Jun 21, 2024
21b5c6e
Merge branch 'main' into fix-missing-imports
junjieqi Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_ivf_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <cstring>
#include <map>
#include <random>
#include <set>
#include <algorithm>
Copy link
Contributor

@junjieqi junjieqi Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing algorithm? I don't see where we use it

Copy link
Author

@mfixman mfixman Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in a std::find call in this file.

Copy link
Contributor

@junjieqi junjieqi Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfixman, I think you are right. I'm wondering if you could put #include in between #include <omp.h> and #include . The format doesn't pass. Once you fix it, I could merge it


#include <gtest/gtest.h>

Expand Down