Fix 4 failing test cases for AIX#3350
Closed
KamathForAIX wants to merge 3 commits intofacebookresearch:mainfrom
Closed
Fix 4 failing test cases for AIX#3350KamathForAIX wants to merge 3 commits intofacebookresearch:mainfrom
KamathForAIX wants to merge 3 commits intofacebookresearch:mainfrom
Conversation
mdouze
reviewed
Apr 5, 2024
Contributor
mdouze
left a comment
mdouze
left a comment
There was a problem hiding this comment.
Please consolidate the big-endian fixes into a single PR, as there is significant overhead on our side to import pull requests.
| const uint16_t code16 = *reinterpret_cast<const uint16_t*>( | ||
| uint16_t code16 = *reinterpret_cast<const uint16_t*>( | ||
| codes + ELEMENT_TO_READ * 5 + 1); | ||
| #if !defined(_MSC_VER) && \ |
Contributor
There was a problem hiding this comment.
see other PR, please use a macro in platform_macros.
Contributor
|
superseded by #3345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is for #3346 where we added support for big endian format as well.