This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Remove local_variables from on_step#411
Closed
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Remove local_variables from on_step#411vreis wants to merge 1 commit intofacebookresearch:masterfrom
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20171981 |
Summary: Pull Request resolved: facebookresearch#411 local_variables makes the code in train_step really hard to read. Killing it from all hooks will take time, so start from a single hook (on_step). Differential Revision: D20171981 fbshipit-source-id: a6f158003926425d9f3e0d5e8489447d49bb2443
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20171981 |
Contributor
|
This pull request has been merged in e29cc72. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
local_variables makes the code in train_step really hard to read. Killing it
from all hooks will take time, so start from a single hook (on_step).
Differential Revision: D20171981