Skip to content

Conversation

@KaleabTessera
Copy link
Contributor

Closes #46.

@facebook-github-bot
Copy link

Hi @KaleabTessera!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Collaborator

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

The CI did not spot it since it is an hydra loading issue.

If you could please sign the CLA, we can merge it straight away

@matteobettini matteobettini changed the title fix: Use correct types to prevent multiwalker init error. [BugFix] Use correct types to prevent multiwalker init error. Jan 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b10d37a) 46.47% compared to head (ac84c23) 46.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   46.47%   46.47%           
=======================================
  Files          64       64           
  Lines        2668     2668           
=======================================
  Hits         1240     1240           
  Misses       1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaleabTessera
Copy link
Contributor Author

Awesome @matteobettini ! I just signed the CLA. Thanks for this work, it looks really nice! 🚀

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2024
@matteobettini matteobettini merged commit 2a9de84 into facebookresearch:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Multiwalker fails to run

4 participants