[Feature] Expose additional arguments for Wandb #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
matteobettini
approved these changes
May 12, 2025
Collaborator
matteobettini
left a comment
matteobettini
left a comment
There was a problem hiding this comment.
This looks great, sorry for taking so long. Only one point about bc-breaking
| # WandbLogger includes: offline, save_dir, project, video_fps | ||
| # wandb.init includes: entity, tags, notes, etc. | ||
| wandb_extra_kwargs: | ||
| project: "benchmarl" |
Collaborator
There was a problem hiding this comment.
So the only problem is that this is backwards compatibility breaking and I would like to avoid that.
What about we keep the project name out and have wandb_extra_kwargs: {}?
Then is someone provides the project in wandb_extra_kwargs and it is different from project_name we tell them through an error
Contributor
Author
There was a problem hiding this comment.
I get you, sounds good.
Contributor
Author
|
Some unrelared failed checks, it seems. |
benchmarl/hydra_config.py
Outdated
| cfg_dict_checked = _type_check_task_config( | ||
| environment_name, inner_task_name, cfg_dict_checked | ||
| ) # Only needed for the warning | ||
| else: |
Collaborator
There was a problem hiding this comment.
We want to run the check anyway no?
Contributor
Author
There was a problem hiding this comment.
sorry I commited a modification linked to another upcoming request 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It exposes
wandb_extra_kwargsin the experiment config to pass additional arguments to bothWandbLoggerandwandb.init.To discuss
ExperimentConfig, e.g. using a field like:wandbas a default logger (base_experiment) really ideal?Happy to iterate.