-
Notifications
You must be signed in to change notification settings - Fork 112
[Feature] Reload experiment without re-passing config #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
df2fc1a
amend
matteobettini 7e35641
amend
matteobettini 8b928f7
amend
matteobettini c60b879
amend
matteobettini de81a74
amend
matteobettini 472aa11
amend
matteobettini 9256472
amend
matteobettini 7ad491b
amend
matteobettini 330f95a
amend
matteobettini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # | ||
| # This source code is licensed under the license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
| # | ||
|
|
||
| import os | ||
| from pathlib import Path | ||
|
|
||
| from benchmarl.algorithms import MappoConfig | ||
| from benchmarl.environments import VmasTask | ||
| from benchmarl.experiment import Experiment, ExperimentConfig | ||
| from benchmarl.models.mlp import MlpConfig | ||
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| experiment_config = ExperimentConfig.get_from_yaml() | ||
| # Save the experiment in the current folder | ||
| experiment_config.save_folder = Path(os.path.dirname(os.path.realpath(__file__))) | ||
| # Checkpoint at every iteration | ||
| experiment_config.checkpoint_interval = ( | ||
| experiment_config.on_policy_collected_frames_per_batch | ||
| ) | ||
| # Run 3 iterations | ||
| experiment_config.max_n_iters = 3 | ||
|
|
||
| task = VmasTask.BALANCE.get_from_yaml() | ||
| algorithm_config = MappoConfig.get_from_yaml() | ||
| model_config = MlpConfig.get_from_yaml() | ||
| critic_model_config = MlpConfig.get_from_yaml() | ||
| experiment = Experiment( | ||
| task=task, | ||
| algorithm_config=algorithm_config, | ||
| model_config=model_config, | ||
| critic_model_config=critic_model_config, | ||
| seed=0, | ||
| config=experiment_config, | ||
| ) | ||
| experiment.run() | ||
|
|
||
| # Now we tell it where to resume from | ||
| restored_experiment = Experiment.reload_from_file( | ||
| ( | ||
| experiment.folder_name | ||
| / "checkpoints" | ||
| / f"checkpoint_{experiment_config.checkpoint_interval}.pt" | ||
| ) | ||
| ) # Restore from first checkpoint | ||
|
|
||
| # We keep te same configuration | ||
matteobettini marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| restored_experiment.run() | ||
matteobettini marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # We can also evaluate | ||
| restored_experiment.evaluate() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for readability i'd suggest adapting the hydra_config util such that you can do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense in the medium term to maintain both hydra-based and non-hydra based saving/loading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think so, the hydra one is more interpretable so it should be the first choice if you can