Add spill support in StreamingWindow addInput() Phase#8631
Conversation
✅ Deploy Preview for meta-velox canceled.
|
5459dcc to
479eef3
Compare
73c2569 to
94d5c70
Compare
There was a problem hiding this comment.
It seems that the data of a partition is preset here to be fully stored in memory. But in the case of spill, the data that comes back from the spill file often cannot fit into memory. What if part of it is in memory and part of it is in the spill file.
There was a problem hiding this comment.
@guhaiyan0221 Currently, only one window partition is supported, either it is in memory or it has been spilled. It does not support a part in memory and a part has been spilled. The reason why the data needs to be loaded back into memory here is because the WindowPartition only accepts data in memory and does not accept spilled data. This is also the second step to do. Thanks.
7ef7d26 to
d7c682c
Compare
|
@mbasmanova @aditi-pandit @zhztheplayer @guhaiyan0221 @zhouyuan Can you help to review? Thanks. |
36af0ce to
47b7bf6
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
#8975