Fix GCC OOM when building by reducing parallelism.#8592
Closed
kgpai wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
majetideepak
approved these changes
Jan 30, 2024
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
We should get to the bottom of this. This change could increase CI time.
majetideepak
requested changes
Jan 30, 2024
Contributor
Author
|
@majetideepak Will just reducing max link jobs help ? |
assignUser
approved these changes
Jan 30, 2024
majetideepak
approved these changes
Jan 30, 2024
Collaborator
Thanks for the clarification. |
Contributor
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
approved these changes
Jan 30, 2024
Contributor
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 12, 2024
…#8592) Summary: **Why** Builds OOM with the following error : https://app.circleci.com/pipelines/github/facebookincubator/velox/43449/workflows/0ecff160-1cb9-4084-9f1e-21ae5b484321/jobs/302064 . We reduced the parallelism recently but dint reduce it for all jobs (facebookincubator#8530) - In this PR we set it for all _debug_ jobs (which are most likely to OOM ) **How** We reduce parallelism as a stop gap to fix this issue and unblock folks. We have an issue here for a long term fix : facebookincubator#8539 Pull Request resolved: facebookincubator#8592 Reviewed By: Yuhta Differential Revision: D53240651 Pulled By: kgpai fbshipit-source-id: 539030018ea3f18d5a3696327f679e7369235291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Builds OOM with the following error : https://app.circleci.com/pipelines/github/facebookincubator/velox/43449/workflows/0ecff160-1cb9-4084-9f1e-21ae5b484321/jobs/302064 . We reduced the parallelism recently but dint reduce it for all jobs (#8530) - In this PR we set it for all debug jobs (which are most likely to OOM )
How
We reduce parallelism as a stop gap to fix this issue and unblock folks. We have an issue here for a long term fix : #8539