misc: Avoid data copy for duplicate result and simplify the impementation #12765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71670857 |
✅ Deploy Preview for meta-velox canceled.
|
duanmeng
approved these changes
Mar 23, 2025
Collaborator
duanmeng
left a comment
duanmeng
left a comment
There was a problem hiding this comment.
@xiaoxmeng LGTM, thanks.
…tion (facebookincubator#12765) Summary: We don't need to copy data for duplicate result for inputs with the same key. Extend row serde to support serialize string view. This optimize cpu/memory and simplify the implementation Also cover the key-dedup in index join test. Reviewed By: wenqiwooo Differential Revision: D71670857
xiaoxmeng
force-pushed
the
export-D71670857
branch
from
b9bb0c8 to
c64c291
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71670857 |
Contributor
|
This pull request has been merged in 61927f4. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
…tion (facebookincubator#12765) Summary: Pull Request resolved: facebookincubator#12765 We don't need to copy data for duplicate result for inputs with the same key. Extend row serde to support serialize string view. This optimize cpu/memory and simplify the implementation Also cover the key-dedup in index join test. Reviewed By: wenqiwooo Differential Revision: D71670857 fbshipit-source-id: d3257ef201fe072e8fba0f2931cd3a6101b8210a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We don't need to copy data for duplicate result for inputs with the same key. Extend row serde to support serialize string view.
This optimize cpu/memory and simplify the implementation
Also cover the key-dedup in index join test.
Reviewed By: wenqiwooo
Differential Revision: D71670857