fix: Ensure proper lifetime of stats in DirectCoalescedLoad #12756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71641158 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Mar 21, 2025
…incubator#12756) Summary: There is a crash in HiveDataSource during the merging of stats because the stats may still be used by the executor in DirectBufferedInput. This means we need the stats to have lifetime exceed that of the executor inside DirectBufferedInput. The simple fix here is to pass a shared_ptr of the stats to DirectBufferedInput so that DirectCoalescedLoad owns a reference to the stats.. Differential Revision: D71641158
yuandagits
force-pushed
the
export-D71641158
branch
from
997c14b to
d833d56
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71641158 |
…incubator#12756) Summary: There is a crash in HiveDataSource during the merging of stats because the stats may still be used by the executor in DirectBufferedInput. This means we need the stats to have lifetime exceed that of the executor inside DirectBufferedInput. The simple fix here is to pass a shared_ptr of the stats to DirectBufferedInput so that DirectCoalescedLoad owns a reference to the stats.. Differential Revision: D71641158
yuandagits
force-pushed
the
export-D71641158
branch
from
d833d56 to
d6562ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71641158 |
Yuhta
approved these changes
Mar 21, 2025
Contributor
|
This pull request has been merged in fb70a03. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
…incubator#12756) Summary: Pull Request resolved: facebookincubator#12756 There is a crash in HiveDataSource during the merging of stats because the stats may still be used by the executor in DirectBufferedInput. This means we need the stats to have lifetime exceed that of the executor inside DirectBufferedInput. The simple fix here is to pass a shared_ptr of the stats to DirectBufferedInput so that DirectCoalescedLoad owns a reference to the stats. DwioCoalescedLoadBase was updated to also cache the stats shared_pointer since it can go on the same code path. Reviewed By: Yuhta Differential Revision: D71641158 fbshipit-source-id: cd114c020c88eac3b8c9921b9df41c55f4bdaa28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is a crash in HiveDataSource during the merging of stats because the stats may still be used by the executor in DirectBufferedInput. This means we need the stats to have lifetime exceed that of the executor inside DirectBufferedInput. The simple fix here is to pass a shared_ptr of the stats to DirectBufferedInput so that DirectCoalescedLoad owns a reference to the stats..
Differential Revision: D71641158