fix(json): Round when converting from json double to integral types #12741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71570565 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
changed the title
kevinwilfong
approved these changes
Mar 20, 2025
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Mar 20, 2025
…ubator#12741) Summary: Currently when given a query like below, velox doesnt round , but rounds down which gives us different results compared to java. ``` SELECT "json_extract"(metrics, '$.eventTimings'), CAST("json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT))), ANY_MATCH( CAST( "json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT)) ), (x) -> (x.inputDelay >= 300) ) FROM ( VALUES '{ "eventTimings": [ { "inputDelay": 299.5999999996274} ] }' ) AS t(metrics) ``` Java returns 300 and velox 299. This PR fixes this. Reviewed By: kevinwilfong Differential Revision: D71570565
…ubator#12741) Summary: Pull Request resolved: facebookincubator#12741 Currently when given a query like below, velox doesnt round , but rounds down which gives us different results compared to java. ``` SELECT "json_extract"(metrics, '$.eventTimings'), CAST("json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT))), ANY_MATCH( CAST( "json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT)) ), (x) -> (x.inputDelay >= 300) ) FROM ( VALUES '{ "eventTimings": [ { "inputDelay": 299.5999999996274} ] }' ) AS t(metrics) ``` Java returns 300 and velox 299. This PR fixes this. Reviewed By: kevinwilfong Differential Revision: D71570565
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71570565 |
Contributor
|
This pull request has been merged in 95b4fb3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
…ubator#12741) Summary: Pull Request resolved: facebookincubator#12741 Currently when given a query like below, velox doesnt round , but rounds down which gives us different results compared to java. ``` SELECT "json_extract"(metrics, '$.eventTimings'), CAST("json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT))), ANY_MATCH( CAST( "json_extract"(metrics, '$.eventTimings') AS ARRAY(ROW(inputdelay BIGINT)) ), (x) -> (x.inputDelay >= 300) ) FROM ( VALUES '{ "eventTimings": [ { "inputDelay": 299.5999999996274} ] }' ) AS t(metrics) ``` Java returns 300 and velox 299. This PR fixes this. Reviewed By: kevinwilfong Differential Revision: D71570565 fbshipit-source-id: e7493578760e8797c7268cd9864954e0db3e3bb7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently when given a query like below, velox doesnt round , but rounds down which gives us different results compared to java.
Java returns 300 and velox 299. This PR fixes this.
Differential Revision: D71570565