misc(memory): Enable preferred memory size override for MemoryPool #12712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71427371 |
✅ Deploy Preview for meta-velox canceled.
|
joeg
changed the title
joeg
added a commit
to joeg/velox
that referenced
this pull request
Mar 19, 2025
…acebookincubator#12712) Summary: Enable overrides for getPreferredSize behavior on a per memory pool basis Reviewed By: xiaoxmeng Differential Revision: D71427371
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71427371 |
joeg
added a commit
to joeg/velox
that referenced
this pull request
Mar 19, 2025
…acebookincubator#12712) Summary: Pull Request resolved: facebookincubator#12712 Enable overrides for getPreferredSize behavior on a per memory pool basis Reviewed By: xiaoxmeng Differential Revision: D71427371
…acebookincubator#12712) Summary: Enable overrides for getPreferredSize behavior on a per memory pool basis Reviewed By: xiaoxmeng Differential Revision: D71427371
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71427371 |
xiaoxmeng
approved these changes
Mar 20, 2025
Contributor
|
This pull request has been merged in a34e1b2. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
…acebookincubator#12712) Summary: Pull Request resolved: facebookincubator#12712 Enable overrides for getPreferredSize behavior on a per memory pool basis Reviewed By: xiaoxmeng Differential Revision: D71427371 fbshipit-source-id: ce4e1c9682de7d00af97ca7eb9a6323c4c8ffd02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Enable overrides for getPreferredSize behavior on a per memory pool basis
Reviewed By: xiaoxmeng
Differential Revision: D71427371