fix: Add Parquet reserved keywords #12625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Collaborator
|
@wraymo Thanks for the fix. Can you add a test? |
Contributor
Author
|
@majetideepak Just added a test. Could you take a look? |
majetideepak
added
the
ready-to-merge
Contributor
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@xiaoxmeng merged this pull request in 68a7033. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
Summary: Summary This PR adds Parquet reserved keywords to handle Parquet files generated by the Presto Java workers. Fixes: facebookincubator#12620. References https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java#L154 https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java#L78 Pull Request resolved: facebookincubator#12625 Reviewed By: pedroerp Differential Revision: D71557476 Pulled By: xiaoxmeng fbshipit-source-id: babeffad086049e9c52cfb16c93a8c2aed1cf029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Parquet reserved keywords to handle Parquet files generated by the Presto Java workers.
Fixes: #12620.
References
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java#L154
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java#L78