feat: Register Spark array_min/max functions with orderable types #12576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
cc @rui-mo @jinchengchenghh , thanks. |
✅ Deploy Preview for meta-velox canceled.
|
zhli1142015
force-pushed
the
array_min_max_o
branch
from
89756eb to
24c16bf
Compare
zhli1142015
force-pushed
the
array_min_max_o
branch
4 times, most recently
from
714564a to
090c150
Compare
zhli1142015
force-pushed
the
array_min_max_o
branch
from
d724f02 to
c6512c7
Compare
zhli1142015
force-pushed
the
array_min_max_o
branch
from
c6512c7 to
49a1084
Compare
rui-mo
changed the title
rui-mo
approved these changes
Mar 19, 2025
rui-mo
added
the
ready-to-merge
Contributor
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@xiaoxmeng merged this pull request in 74b451a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Apr 4, 2025
…cebookincubator#12576) Summary: https://github.com/apache/spark/blob/84f5fd99fef1ad3a2b2c41dbee09c60560479c11/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L2341 Pull Request resolved: facebookincubator#12576 Reviewed By: bikramSingh91 Differential Revision: D71479672 Pulled By: xiaoxmeng fbshipit-source-id: 8e5471ac471886aeb7fa14446caf2c9d2dd0d517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/spark/blob/84f5fd99fef1ad3a2b2c41dbee09c60560479c11/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L2341