fix: modeling window coverage considers all actual dates data + legacy InputCollect for BA bug #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y data covers until end of month)
facebook-github-bot
added
the
CLA Signed
laresbernardo
changed the title
gufengzhou
requested changes
Jan 21, 2025
Contributor
gufengzhou
left a comment
gufengzhou
left a comment
There was a problem hiding this comment.
See my comment reg. the allocator.R change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve modeling window coverage accuracy by considering all real dates in the data. With this change:
The results are exactly the same, it's a matter of "correct" coverage. For monthly data, if modeling window covers from "2024-01-01" to "2024-12-31", the data for last month is "2024-12-01" but it actually covers until "2024-12-31".
This logic is triggered only when window_end is not provided.
Also, fixed issue with legacy InputCollect and budget allocator using paid_media_selected (similar to #1194)