Incorrect `window_end` when using `robyn_read(json_file)`

[ghltk]

Hi Robyn team,

I found a potential issue when reloading a model using robyn_read(json_file).

In my case:

• The raw data ends at 2025-04-14, confirmed via json_file$Extras$raw_data$date
• But json_file$InputCollect$window_end is incorrectly set to 2025-04-20

max(json_file$Extras$raw_data$date)
[1] "2025-04-14" # <-- correct
json_file$InputCollect$window_end
[1] "2025-04-20" # <-- incorrect

This causes a refresh issue. Even after adding the next week of data, I get the following error:
-> Not enough data for this refresh. Input data from date 2025-04-27 or later required

It looks like window_end is not correctly reconstructed, and that prevents proper model refresh even when enough data is available

Questions:

1. Is this a known issue with robyn_read() incorrectly setting window_end?
2. Is the refresh feature under active development? It feels somewhat unstable currently.

Robyn Version 3.12.0.9006

Thanks as always for your work and support on Robyn!
@gufengzhou

[ghltk]

Additionally, I’d like to ask if there is any ongoing review or development related to the following issue shared here:
https://www.facebook.com/share/p/197zA5NHeh/
It would be great to hear any updates or context regarding this.

[laresbernardo]

@ghltk Try with the fix_1270 branch and see if the issue gets fixed. Install this version with remotes::install_github("facebookexperimental/Robyn/R", ref = "fix_1270").

This occurred due to the change in the logic from window_end to reflect the last available true date instead of the last date in the dataset. For monthly data, for example,the last day is not 2025-06-01 but 2025-06-30.

[laresbernardo]

@ghltk any feedback?

[ghltk]

@laresbernardo Thanks for the update! I'll test the fix_1270 branch and share feedback shortly.

[ghltk]

@laresbernardo I’ve tested the fix_1270 branch, and I can confirm that the date logic now works correctly with the updated version. Thanks for the fix!

[ghltk]

@laresbernardo

Hi, the fix_1270 branch can’t be downloaded right now via:
I’ll probably need to download it more than once — could you make sure it stays accessible?

Thanks!

[laresbernardo]

Hi @ghltk No need. The fix has been merged with dev, so if you install dev version, you'll have this fix as well. Simply run: remotes::install_github("facebookexperimental/Robyn/R")

[cynthia10wang]

I had an error ealier on about the refreshEnd when running the refresh function on AWS. I found out that it's because the InputCollectRF$window_end is charactor format, so when checking whether it's included in totalDates with this newly added if statement, it leads to the wrong refreshEnd. Interesting that I didnt have issues running locally with Rstudio though with the same json file and raw data.

On AWS, R version 4.2.2, lubridate 1.8.0
Local Rstudio, R version 4.3.2, lubridate 1.9.3，Both are usingRobyn 3.12.1, dplyr 1.1.4

Would it be safer to add as.date for InputCollectRF$window_end?