Fixing Docusaurus migration issues #1771
Conversation
…ns. * upgrade docusaurus
website/static/css/custom.css
Outdated
| } | ||
|
|
||
| .hero .text, | ||
| .hero .minitext, |
There was a problem hiding this comment.
Nit - Double space between selectors.
There was a problem hiding this comment.
Turned off auto-format and forgot to turn it on 🤦🏻♂️ Thanks for noticing!
website/static/css/custom.css
Outdated
| box-sizing: border-box; | ||
| padding: 0 15px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit - Would be good to add a newline here!
website/package.json
Outdated
| "devDependencies": { | ||
| "docusaurus": "1.0.15" | ||
| "docusaurus": "1.1.0", | ||
| "opn": "5.3.0" |
There was a problem hiding this comment.
Hmm why do you need to add this? Are you getting an error? It should be installed as part of Docusaurus core.
There was a problem hiding this comment.
My bad, it's a bug in Docusaurus. Submitted a fix for it in facebook/docusaurus#680
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@NoamELB has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
This PR introduces new versions of dependent libraries like React and Immutable, so it's doing more than just fixing Docusaurus issues. Would be good to not include upgrading changes in this diff but the decision is up to you.
If you go ahead and upgrade the libraries in this PR, please check thoroughly before merging!
website/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "docusaurus": "1.0.15" | ||
| "docusaurus": "1.1.2" |
There was a problem hiding this comment.
We ran into a problem of npm outage causing 1.1.2 to not be downloadable. We just released 1.1.3 as a workaround even though there aren't much changes. Could you use 1.1.3 just to be safe? Sorry and thanks!
website/pages/en/index.js
Outdated
| </p> | ||
|
|
||
| <div id="rich-example"></div> | ||
| <div className="hide-in-mobile" id="rich-example"></div> |
There was a problem hiding this comment.
Just a small nit, I think hide-on-mobile sounds more correct.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@NoamELB has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** Fixes #1765 Includes: 1. Upgrading Docusaurus to 1.1.0, which fix the sticky footer issue. 2. Using production assets (for react, react-dom, immutable, babel-core) instead of development ones. 3. Supporting small screens with css. More details in the issue. **Test Plan** Live site with the fixes: https://noamelb.github.io/draft-js * Wide desktop:  * Mobile:  * Mobile Docs:  Closes facebookarchive/draft-js#1771 Reviewed By: yangshun Differential Revision: D8095846 Pulled By: yangshun fbshipit-source-id: a07720785d787a6455c2704b2f4413b0572af321
Summary: **Summary** Fixes #1765 Includes: 1. Upgrading Docusaurus to 1.1.0, which fix the sticky footer issue. 2. Using production assets (for react, react-dom, immutable, babel-core) instead of development ones. 3. Supporting small screens with css. More details in the issue. **Test Plan** Live site with the fixes: https://noamelb.github.io/draft-js * Wide desktop:  * Mobile:  * Mobile Docs:  Closes facebookarchive/draft-js#1771 Reviewed By: yangshun Differential Revision: D8095846 Pulled By: yangshun fbshipit-source-id: a07720785d787a6455c2704b2f4413b0572af321
3 participants
Summary
Fixes #1765
Includes:
More details in the issue.
Test Plan
Live site with the fixes: https://noamelb.github.io/draft-js
Wide desktop:
Mobile:
Mobile Docs:
