Cleaner threadPool initialization #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #3121, which is correct even though it failed at its intended objective to fix #3119.
This PR just ensures that the
queueand thepoolare cleanly set to zero,so that no uninitialized noise can influence the behavior.
These memory areas are small, and employed in a context of much higher load (multi-threading, context-switching, etc.),
so there is no expectation of performance impact.
It just turns out that #3119 is more likely triggered by a race condition than a side effect of uninitialization.
Yet, the patch looks useful, as it removes a potential source of random issue considered during the investigation for #3119.