Documentation and minor refactor to clarify MT memory management #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embg
changed the title
Cyan4973
reviewed
Jan 16, 2022
Contributor
|
The additional comments are welcome, and correct. I just have one question about an included modification of parameters order. |
embg
force-pushed
the
mt_memory_readability
branch
from
ee20c01 to
9b6dfed
Compare
Cyan4973
approved these changes
Jan 18, 2022
Contributor
|
Look good to me ! |
felixhandte
reviewed
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies some misunderstandings I had while working on #2232. In particular:
ZSTDMT_initCStream_internalcan reuse aZSTDMT_CCtxfrom a previous compression, and memory usage depends on the previous compression's parameters.mtctx->bufPool. Formtctx->seqPool, the true bound is lower.