Skip to content

Mark Huffman Decoder Assembly noexecstack on All Architectures #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Mark Huffman Decoder Assembly noexecstack on All Architectures #2964

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a9d1ec
Mark Huffman Decoder Assembly `noexecstack` on All Architectures
felixhandte Dec 30, 2021
35208f7
Add Test Validating Stack is not Executable in playTests.sh
felixhandte Dec 30, 2021
4620ce6
Makefiles: Add `noexecstack` Options to Compilation and Linking
felixhandte Jan 5, 2022
b12eddd
Write `GNU-stack` Section on All ELF Architectures
felixhandte Jan 5, 2022
ef1f9e8
Restrict `GNU-stack` Note to GNU Assemblers
felixhandte Jan 5, 2022
ff5d1da
Clean Up Debugging Statements
felixhandte Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/decompress/huf_decompress_amd64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#include "../common/portability_macros.h"

#if ZSTD_ENABLE_ASM_X86_64_BMI2

/* Stack marking
* ref: https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart
*/
#if defined(__linux__) && defined(__ELF__)
.section .note.GNU-stack,"",%progbits
#endif

#if ZSTD_ENABLE_ASM_X86_64_BMI2

/* Calling convention:
*
* %rdi contains the first argument: HUF_DecompressAsmArgs*.
Expand Down