Skip to content

Conversation

@binhdvo
Copy link
Contributor

@binhdvo binhdvo commented Jun 9, 2021

Fixes command line flag from #2703

Adds --long-level flag which behaves as -# except supporting negative values as fast compression levels.

--long- is intended to be the prefix for any future parameters that should have a version which accepts negative values.

Copy link
Contributor

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss a rewording of this task for improved clarity

@binhdvo binhdvo changed the title Add support for --long-level flag Add support for negative values in advanced flags Jun 11, 2021
@binhdvo binhdvo merged commit 89127e5 into facebook:dev Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants