Format File Sizes Human-Readable in the CLI#2702

Merged

felixhandte merged 26 commits into

facebook:devfrom

felixhandte:human_size_output

Jun 10, 2021

Commits on Jun 10, 2021

Make the CLI output the file sizes in human readable format

scottchiefbaker
authored and
felixhandte
committed
Put the human_size() function in util.c

scottchiefbaker
authored and
felixhandte
committed
Convert names to CamelCase

scottchiefbaker
authored and
felixhandte
committed
Make the variable types match

scottchiefbaker
authored and
felixhandte
committed
Move the variable declarations to the top

scottchiefbaker
authored and
felixhandte
committed
Use human_size() in the benchmark output also

scottchiefbaker
authored and
felixhandte
committed
Use human_size() on the "multiple files compressed" output also

scottchiefbaker
authored and
felixhandte
committed
Convert tabs to spaces

scottchiefbaker
authored and
felixhandte
committed
human_size() should use size_t

scottchiefbaker
authored and
felixhandte
committed
Use unsigned long instead to help with some tests

scottchiefbaker
authored and
felixhandte
committed
Update humanSize() to skip the big numbers (it requires 64 bit)

scottchiefbaker
authored and
felixhandte
committed
Try unsigned long long

scottchiefbaker
authored and
felixhandte
committed
Try enabling the BIG strings now the unsigned long long is in effect

scottchiefbaker
authored and
felixhandte
committed
Some fixes to address things @felixhandte found

scottchiefbaker
authored and
felixhandte
committed
Attempt to fix a failing test with help from @aqrit

scottchiefbaker
authored and
felixhandte
committed
Avoid `snprintf()` in Preparing Human-Readable Sizes; Improve Formatting
felixhandte
committed
Fix Integer Constants; Fix Comparison
felixhandte
committed
In Verbose Mode, Preserve Full Precision Where Possible
felixhandte
committed
Change Suffix (e.g., "G" -> " GB")
felixhandte
committed
Fix Whitespace
felixhandte
committed
Apply to Other Print Statement as Well
felixhandte
committed
Require `-vv` to Enable Full Precision
felixhandte
committed
Switch to Binary Size Prefixes (e.g., "MB" -> "MiB")
felixhandte
committed
Convert Other Size Displays to Use Human-Readable Formatting
felixhandte
committed
Update Tests to Reflect New Formatting
felixhandte
committed
Whitespace Fixes to Improve Cross-Line Alignment
felixhandte
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Format File Sizes Human-Readable in the CLI#2702

Format File Sizes Human-Readable in the CLI#2702
felixhandte merged 26 commits into
facebook:devfrom
felixhandte:human_size_output

Commits on Jun 10, 2021

Make the CLI output the file sizes in human readable format

Put the human_size() function in util.c

Convert names to CamelCase

Make the variable types match

Move the variable declarations to the top

Use human_size() in the benchmark output also

Use human_size() on the "multiple files compressed" output also

Convert tabs to spaces

human_size() should use size_t

Use unsigned long instead to help with some tests

Update humanSize() to skip the big numbers (it requires 64 bit)

Try unsigned long long

Try enabling the BIG strings now the unsigned long long is in effect

Some fixes to address things @felixhandte found

Attempt to fix a failing test with help from @aqrit

Avoid `snprintf()` in Preparing Human-Readable Sizes; Improve Formatting

Fix Integer Constants; Fix Comparison

In Verbose Mode, Preserve Full Precision Where Possible

Change Suffix (e.g., "G" -> " GB")

Fix Whitespace

Apply to Other Print Statement as Well

Require `-vv` to Enable Full Precision

Switch to Binary Size Prefixes (e.g., "MB" -> "MiB")

Convert Other Size Displays to Use Human-Readable Formatting

Update Tests to Reflect New Formatting

Whitespace Fixes to Improve Cross-Line Alignment