fix ubsan test errors #2502
Merged
fix ubsan test errors #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows recovering from pointer overflow
terrelln
approved these changes
Feb 19, 2021
Contributor
terrelln
left a comment
terrelln
left a comment
There was a problem hiding this comment.
FYI this won't work with gcc versions older than 8.0.0, but that shouldn't be a problem.
Contributor
|
I've fixed the LLVM fuzzers in #2503. |
terrelln
reviewed
Feb 19, 2021
Makefile
Outdated
|
|
||
| uasan: clean | ||
| $(MAKE) test CC=clang MOREFLAGS="-g -fno-sanitize-recover=all -fsanitize-recover=signed-integer-overflow -fsanitize=address,undefined -Werror" | ||
| $(MAKE) test CC=clang MOREFLAGS="-g -fno-sanitize-recover=all -fsanitize-recover=signed-integer-overflow -fsanitize-recover=pointer-overflow -fsanitize=address,undefined -Werror" |
Contributor
There was a problem hiding this comment.
Can we remove -fsanitize-recover=signed-integer-overflow?
Contributor
Author
There was a problem hiding this comment.
Yes.
At least on my local platform, it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows recovering from pointer overflow.