Skip to content

Conversation

@myzhang1029
Copy link
Contributor

Add a static function LONG_TELL for the forth #if branch

It looks like the only way to invoke the edited code is through the --list option of the cli.
I tested it on a Windows 7 machine, for both small and large(3 GiB) files, and they worked as expected.

Add a static function LONG_TELL for the forth #if branch
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the patch!

@terrelln
Copy link
Contributor

I will merge this once the bot tags this as CLA signed.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@terrelln
Copy link
Contributor

Fixes #1591.

@terrelln terrelln merged commit 585b5a1 into facebook:dev Apr 25, 2019
@myzhang1029 myzhang1029 deleted the long-tell branch April 25, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants