-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Improve completeSegment for safer DOM manipulation #34996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Enhance completeSegment function to handle cases where segment or placeholder nodes may not exist, preventing potential DOM exceptions.
|
Hi @leog! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Enhance completeSegment function to handle cases where segment or placeholder nodes may not exist, preventing potential DOM exceptions.
It's related to this kind of error: vercel/next.js#70048
How did you test this change?
Tried to reproduce the original issue but it's very difficult and unpredictable. Since it comes from using Next.js and the
loading.tsxSuspense boundary, it's not that straightforward to reproduce.