[Flight] Do not redefine debugInfo on JSX elements #34984
+36
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to 19.2 in Parcel, I'm seeing "Cannot redefine property _debugInfo" errors, which appear to be caused by #34524. Looks like
_debugInfois already defined asnullin some cases (e.g. JSX elements), and marked as non-configurable/writable. ThenmoveDebugInfoFromChunkToInnerValuetries to re-define it.This happens when you directly export a JSX element as a client reference. In that case the React Element object is frozen, so the
_debugInfoproperty cannot be written to.I added a test for this and made a small workaround that simply skips setting
_debugInfoif it is not writable, but idk if this is the correct fix.