Skip to content

[Flight] Wait for both streams to end before closing the response #34301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

[Flight] Wait for both streams to end before closing the response #34301

merged 2 commits into from
Aug 26, 2025

Conversation

@unstubbable
Copy link
Collaborator

@unstubbable unstubbable commented Aug 26, 2025

When a debug channel is defined, we must ensure that we don't close the Flight Client's response when the debug channel's readable is done, but the RSC stream is still flowing. Now, we wait for both streams to end before closing the response.

@unstubbable
[Flight] Wait for both streams to end before closing the response
0e60bcb 
When a debug channel is defined, we must ensure that we don't close the
Flight Client's response when the debug channel's readable is done, but
the RSC stream is still flowing. Now, we wait for both streams to end
before closing the response.
@meta-cla meta-cla bot added the CLA Signed label Aug 26, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 26, 2025
@react-sizebot
Copy link

react-sizebot commented Aug 26, 2025 •
edited
Loading

Comparing: ad4ecb6...9564abc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.82 kB 655.82 kB = 115.31 kB 115.31 kB
facebook-www/ReactDOM-prod.classic.js = 675.59 kB 675.59 kB = 118.54 kB 118.54 kB
facebook-www/ReactDOM-prod.modern.js = 666.02 kB 666.02 kB = 116.87 kB 116.87 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.38% 130.33 kB 130.83 kB +0.31% 23.86 kB 23.93 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.38% 130.33 kB 130.83 kB +0.31% 23.86 kB 23.93 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.35% 132.08 kB 132.53 kB +0.29% 24.15 kB 24.22 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.35% 132.08 kB 132.53 kB +0.29% 24.15 kB 24.22 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.34% 133.42 kB 133.88 kB +0.28% 24.39 kB 24.46 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.34% 133.42 kB 133.88 kB +0.28% 24.39 kB 24.46 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.34% 133.55 kB 134.01 kB +0.28% 24.43 kB 24.50 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.34% 133.55 kB 134.01 kB +0.28% 24.43 kB 24.50 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.29% 171.83 kB 172.33 kB +0.27% 30.50 kB 30.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.26% 173.57 kB 174.03 kB +0.26% 30.77 kB 30.85 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.26% 174.92 kB 175.38 kB +0.23% 31.02 kB 31.09 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.26% 175.05 kB 175.50 kB +0.23% 31.05 kB 31.12 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.25% 124.63 kB 124.94 kB +0.23% 23.12 kB 23.17 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.25% 124.63 kB 124.94 kB +0.23% 23.12 kB 23.17 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.24% 127.78 kB 128.09 kB +0.23% 23.62 kB 23.67 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.24% 127.78 kB 128.09 kB +0.23% 23.62 kB 23.67 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.24% 127.91 kB 128.22 kB +0.23% 23.65 kB 23.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.24% 127.91 kB 128.22 kB +0.23% 23.65 kB 23.71 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 56.83 kB 56.72 kB = 11.32 kB 11.32 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 56.62 kB 56.50 kB +0.02% 11.23 kB 11.23 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 56.26 kB 56.14 kB = 11.21 kB 11.20 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 56.26 kB 56.14 kB = 11.21 kB 11.20 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 56.04 kB 55.93 kB = 11.12 kB 11.12 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 56.04 kB 55.93 kB = 11.12 kB 11.12 kB

Generated by 🚫 dangerJS against 9564abc

@unstubbable unstubbable marked this pull request as ready for review August 26, 2025 14:19
@unstubbable unstubbable requested a review from eps1lon August 26, 2025 14:20
@unstubbable unstubbable merged commit cacc20e into facebook:main Aug 26, 2025
241 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2025
@unstubbable
[Flight] Wait for both streams to end before closing the response (#3…
621eb5e 
…4301)

When a debug channel is defined, we must ensure that we don't close the
Flight Client's response when the debug channel's readable is done, but
the RSC stream is still flowing. Now, we wait for both streams to end
before closing the response.

DiffTrain build for [cacc20e](cacc20e)
github-actions bot pushed a commit that referenced this pull request Aug 26, 2025
@unstubbable
[Flight] Wait for both streams to end before closing the response (#3…
41f244f 
…4301)

When a debug channel is defined, we must ensure that we don't close the
Flight Client's response when the debug channel's readable is done, but
the RSC stream is still flowing. Now, we wait for both streams to end
before closing the response.

DiffTrain build for [cacc20e](cacc20e)
@nextjs-bot nextjs-bot mentioned this pull request Aug 26, 2025
Merged
@unstubbable unstubbable mentioned this pull request Aug 27, 2025
Merged
@unstubbable unstubbable deleted the fix-flight-client-close-response branch August 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unstubbable @react-sizebot @eps1lon