[DevTools] Add "suspended by" Section to Component Inspector Sidebar#34012
Merged
sebmarkbage merged 7 commits intofacebook:mainfrom Jul 28, 2025
Merged
[DevTools] Add "suspended by" Section to Component Inspector Sidebar#34012sebmarkbage merged 7 commits intofacebook:mainfrom
sebmarkbage merged 7 commits intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
hoxyq
approved these changes
Jul 28, 2025
Comment on lines
+758
to
+761
| inspectedElement.suspendedBy = cleanForBridge( | ||
| inspectedElement.suspendedBy, | ||
| createIsPathAllowed('suspendedBy'), | ||
| ); |
Contributor
There was a problem hiding this comment.
Just an empty array here, maybe?
Contributor
Author
There was a problem hiding this comment.
It's not the same because this converts it to DehydratedData which gets hydrated on the frontend.
eps1lon
approved these changes
Jul 28, 2025
sebmarkbage
added a commit
that referenced
this pull request
Jul 28, 2025
…lative to others (#34016) Stacked on #34012. This shows a time track for when some I/O started and when it finished relative to other I/O in the same component (or later in the same suspense boundary). This is not meant to be a precise visualization since the data might be misleading if you're running this in dev which has other perf characteristics anyway. It's just meant to be a general way to orient yourself in the data. We can also highlight rejected promises here. The color scheme is the same as Chrome's current Performance Track colors to add continuity but those could change. <img width="478" height="480" alt="Screenshot 2025-07-27 at 11 48 03 PM" src="https://github.com/user-attachments/assets/545dd591-a91f-4c47-be96-41d80f09a94a" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This collects the ReactAsyncInfo between instances. It associates it with the parent. Typically this would be a Server Component's Promise return value but it can also be Promises in a fragment. It can also be associated with a client component when you pass a Promise into the child position e.g.
<div>{promise}</div>then it's associated with the div. If an instance is filtered, then it gets associated with the parent of that's unfiltered.The stack trace currently isn't source mapped. I'll do that in a follow up.
We also need to add a "short name" from the Promise for the description (e.g. url). I'll also add a little marker showing the relative time span of each entry.