Skip to content

Fix Broken Links In Documentation #28321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2024
Merged

Fix Broken Links In Documentation #28321

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c02d5c3
fix documentation link for hidpi canvas
justindhillon Feb 13, 2024
bc1caa4
https://www.w3.org/TR/custom-elements/
justindhillon Feb 13, 2024
18cebff
https://www.w3.org/TR/custom-elements/
justindhillon Feb 13, 2024
83c2098
https://github.com/facebookarchive/fixed-data-table/blob/master/src/v…
justindhillon Feb 13, 2024
6f3793f
https://github.com/facebook/react/blob/main/packages/react-cache/src/…
justindhillon Feb 13, 2024
106f652
https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png
justindhillon Feb 13, 2024
3ba1d82
Merge branch 'facebook:main' into broken-links
justindhillon Feb 28, 2024
2a822b2
https://html.spec.whatwg.org/multipage/custom-elements.html#custom-el…
justindhillon Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/suspense/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class TextInputFixtures extends React.Component {

<Fixture>
<SuspendyTree>
<img src="https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png" />
<img src="https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png" />
React is cool
</SuspendyTree>
</Fixture>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/devtools/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {createContext} from 'react';
// TODO (cache) Remove this cache; it is outdated and will not work with newer APIs like startTransition.

// Cache implementation was forked from the React repo:
// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCache.js
// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCacheOld.js
//
// This cache is simpler than react-cache in that:
// 1. Individual items don't need to be invalidated.
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-timeline/src/view-base/Surface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export type ViewRefs = {
hoveredView: View | null,
};

// hidpi canvas: https://www.html5rocks.com/en/tutorials/canvas/hidpi/
// hidpi canvas: https://web.dev/articles/canvas-hidipi
function configureRetinaCanvas(
canvas: HTMLCanvasElement,
height: number,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @flow
*/

// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js
// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js

export type NormalizedWheelDelta = {
deltaX: number,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3698,7 +3698,7 @@ export function pushStartInstance(
return pushSelfClosing(target, props, type);
}
// These are reserved SVG and MathML elements, that are never custom elements.
// https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts
// https://www.w3.org/TR/custom-elements/
Copy link
Member

@rickhanlonii rickhanlonii Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right link: https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts

Same below

Copy link
Contributor Author

@justindhillon justindhillon Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! It has been updated with new link.

case 'annotation-xml':
case 'color-profile':
case 'font-face':
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/shared/isCustomElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function isCustomElement(tagName: string, props: Object): boolean {
// These are reserved SVG and MathML elements.
// We don't mind this list too much because we expect it to never grow.
// The alternative is to track the namespace in a few places which is convoluted.
// https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts
// https://www.w3.org/TR/custom-elements/
case 'annotation-xml':
case 'color-profile':
case 'font-face':
Expand Down