Skip to content

Conversation

@kassens
Copy link
Member

@kassens kassens commented Dec 4, 2023

hermes-parser is recommended for all Flow files as it supports the latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after

@kassens kassens requested review from jackpope and noahlemen December 4, 2023 17:19
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 4, 2023
@kassens kassens merged commit f391cda into facebook:main Dec 4, 2023
@kassens kassens deleted the warnings-parser branch December 4, 2023 18:25
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
`hermes-parser` is recommended for all Flow files as it supports the
latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
`hermes-parser` is recommended for all Flow files as it supports the
latest features. I noticed we were still using babel here.

Test Plan:
no diff in output before and after

DiffTrain build for commit f391cda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants