Skip to content

Conversation

@rbalicki2
Copy link
Contributor

  • Minor change that fixes code highlighting in VSCode in a particular file

Summary

  • See above

How did you test this change?

👀

In particular, before:
Screen Shot 2022-08-30 at 2 10 04 PM

And after:

Screen Shot 2022-08-30 at 2 08 33 PM

But this isn't synced with getWrappedName in getComponentNameFromFiber

  • Turns out, it wasn't synced before this commit, too!

* Minor change that fixes code highlighting in VSCode in a particular file
Copy link
Contributor

@tyao1 tyao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why was the code highlighting broken?

@rbalicki2 rbalicki2 merged commit 47867a7 into facebook:main Aug 31, 2022
@rbalicki2
Copy link
Contributor Author

VSCode code highlighting (at least with my out-of-the-box setup) gets confused whenever there is a cast of the form (variable: Type) or the like. Notice that in the "fixed" version the return keyword is highlighted incorrectly.

In the first example, though, it somehow guessed incorrectly that the last back tick was... something else? I don't have a great theory as to why it might be. But in any case, everything afterward is considered part of the string.

rickhanlonii pushed a commit that referenced this pull request Oct 5, 2022
* Minor change that fixes code highlighting in VSCode in a particular file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants