Skip to content

#22988 - Fix Bug: @license header in React 18 bundles contains vundefined #23004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

#22988 - Fix Bug: @license header in React 18 bundles contains vundefined #23004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986e986
Fix Bug: @license header in React 18 bundles contains vundefined
vitaliemiron Dec 20, 2021
4c0f650
Remove React version from the header comment
vitaliemiron Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions scripts/rollup/wrappers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const {resolve} = require('path');
const {readFileSync} = require('fs');
const {bundleTypes, moduleTypes} = require('./bundles');
const reactVersion = require('../../package.json').version;

const {
NODE_ES2015,
Expand Down Expand Up @@ -54,7 +53,8 @@ const license = ` * Copyright (c) Facebook, Inc. and its affiliates.
const wrappers = {
/***************** NODE_ES2015 *****************/
[NODE_ES2015](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -67,7 +67,8 @@ ${source}`;

/***************** NODE_ESM *****************/
[NODE_ESM](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -78,7 +79,8 @@ ${source}`;

/***************** UMD_DEV *****************/
[UMD_DEV](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -88,7 +90,8 @@ ${source}`;

/***************** UMD_PROD *****************/
[UMD_PROD](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -98,7 +101,8 @@ ${license}

/***************** UMD_PROFILING *****************/
[UMD_PROFILING](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -108,7 +112,8 @@ ${license}

/***************** NODE_DEV *****************/
[NODE_DEV](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -125,7 +130,8 @@ ${source}

/***************** NODE_PROD *****************/
[NODE_PROD](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -135,7 +141,8 @@ ${source}`;

/***************** NODE_PROFILING *****************/
[NODE_PROFILING](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand Down Expand Up @@ -294,7 +301,8 @@ ${source}`;
const reconcilerWrappers = {
/***************** NODE_DEV (reconciler only) *****************/
[NODE_DEV](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -313,7 +321,8 @@ ${source}

/***************** NODE_PROD (reconciler only) *****************/
[NODE_PROD](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand All @@ -327,7 +336,8 @@ ${source}

/***************** NODE_PROFILING (reconciler only) *****************/
[NODE_PROFILING](source, globalName, filename, moduleType) {
return `/** @license React v${reactVersion}
return `/**
* @license React
* ${filename}
*
${license}
Expand Down