Use toMatchInlineSnapshot for dehydrated values #20618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 1214b30...56fcc69 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad46678:
|
eps1lon
changed the title
eps1lon
force-pushed
the
devtools-replace-cache-serialize-dehydrated
branch
from
d3b923b to
ad46678
Compare
eps1lon
force-pushed
the
devtools-replace-cache-serialize-dehydrated
branch
from
ad46678 to
9d8854e
Compare
eps1lon
force-pushed
the
devtools-replace-cache-serialize-dehydrated
branch
4 times, most recently
from
bb557cd to
634c8b6
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
devtools-replace-cache-serialize-dehydrated
branch
from
634c8b6 to
0be6c2f
Compare
Contributor
|
Merge conflicts~ |
This reverts commit 9fd6735.
Same reason why jest can fail with "could not find all inline snapshots". Since we don't need "done()" on async tests we can safely remove it.
eps1lon
force-pushed
the
devtools-replace-cache-serialize-dehydrated
branch
from
0be6c2f to
ee699c0
Compare
Collaborator
Author
@bvaughn Resolved |
bvaughn
reviewed
Apr 8, 2021
packages/react-devtools-shared/src/__tests__/dehydratedValueSerializer.js
Show resolved
Hide resolved
packages/react-devtools-shared/src/__tests__/inspectedElementSerializer.js
Show resolved
Hide resolved
packages/react-devtools-shared/src/__tests__/treeContextStateSerializer.js
Show resolved
Hide resolved
bvaughn
approved these changes
Apr 26, 2021
Contributor
|
Thanks! |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There may be other places where we want to use the serializer. I only reverted
9fd6735(#20548) and tried to fixyarn test-build-devtoolsTest Plan