Skip to content

Support inner component _debugOwner in memo #18659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Support inner component _debugOwner in memo #18659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
803bdce
Support inner component _debugOwner in memo
hanq08 Apr 17, 2020
68408a4
test with devtool context
hanq08 Apr 18, 2020
51a00f0
remove memo test
hanq08 Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-reconciler/src/ReactFiberBeginWork.new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,9 @@ function updateMemoComponent(
child.ref = workInProgress.ref;
child.return = workInProgress;
workInProgress.child = child;
if (__DEV__) {
child._debugOwner = workInProgress;
}
return child;
}
if (__DEV__) {
Expand Down
16 changes: 16 additions & 0 deletions packages/react-reconciler/src/__tests__/ReactMemo-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,5 +497,21 @@ describe('memo', () => {
expect(root).toMatchRenderedOutput('1');
});
});

it('inner component of react memo should have _debugOwner set', async () => {
const InComponent = React.forwardRef((props, ref) => <div ref={ref} />);
const Outer = React.memo(InComponent);
const App = () => {
const ref = React.createRef();
return <Outer ref={ref}>Click me! </Outer>;
};
ReactNoop.render(<App />);
expect(Scheduler).toFlushWithoutYielding();
const innerFiber = ReactNoop.getRoot().current.child.child.child;
const innerFiberOwner = innerFiber._debugOwner;
expect(innerFiber.type.$$typeof).toBe(Symbol.for('react.forward_ref'));
expect(innerFiberOwner).not.toBeNull();
expect(innerFiberOwner.type.$$typeof).toBe(Symbol.for('react.memo'));
});
}
});