Add UMD production+profiling entry points #13642
Merged
+177
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MD shim to schedule package.
bvaughn
force-pushed
the
add-umd-profiling-entry-points
branch
from
c30177e to
18b4a27
Compare
Details of bundled changes.Comparing: 4bcee56...80ffb58 schedule
react
react-dom
Generated by 🚫 dangerJS |
gaearon
approved these changes
Sep 14, 2018
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Should we add the new Schedule bundle to the test that verifies matching exports?
Contributor
Author
|
Whoops, yeah. Thanks for catching that. |
| ${source}`; | ||
| }, | ||
|
|
||
| /***************** UMD_PROFILING *****************/ |
Contributor
There was a problem hiding this comment.
Seems more '*' than others 😄
This was referenced Sep 19, 2018
ghost
mentioned this pull request
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
* Added UMD_PROFILING type to react-dom and scheduling package. Added UMD shim to schedule package. * Added new schedule umd prod+prof bundle to API test
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Added UMD_PROFILING type to react-dom and scheduling package. Added UMD shim to schedule package. * Added new schedule umd prod+prof bundle to API test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13634 by enabling apps that use the UMD build of React (and co) to use the new profiling and tracing APIs in production mode.
Note that this PR builds on top of PR #13641. The only commit this branch contains is 18b4a27.
Changes
reactpackage (since it's not necessary).UMD_PROFILINGbundle type and plugged intoreactandreact-dom.umd/schedule.profiling.min.jsshim toschedulepackage. (This is just a copy ofumd/schedule.production.min.js.)