Include react-is in FB build targets #12458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abanshwan
approved these changes
Mar 26, 2018
Details of bundled changes.Comparing: e9ba8ec...b1f10a4 react-is
Generated by 🚫 dangerJS |
gaearon
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently,
react-iswas added as a dependency to the shallow renderer (#12392). This breaks the FB sync script, since we were not previously syncing thereact-ispackage.I'm not super familiar with www internals, but I think the simplest solution is to tag
react-isas one of the FB build targets (so that it gets synced) and then add a yarn stub for it.