Skip to content

Use binary numbers representation directly #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Use binary numbers representation directly #11873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/shared/ReactTypeOfSideEffect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
export type TypeOfSideEffect = number;

// Don't change these two values:
export const NoEffect = 0; // 0b00000000
export const PerformedWork = 1; // 0b00000001
export const NoEffect = 0b00000000;
export const PerformedWork = 0b00000001;

// You can change the rest (and add more).
export const Placement = 2; // 0b00000010
export const Update = 4; // 0b00000100
export const PlacementAndUpdate = 6; // 0b00000110
export const Deletion = 8; // 0b00001000
export const ContentReset = 16; // 0b00010000
export const Callback = 32; // 0b00100000
export const Err = 64; // 0b01000000
export const Ref = 128; // 0b10000000
export const Placement = 0b00000010;
export const Update = 0b00000100;
export const PlacementAndUpdate = 0b00000110;
export const Deletion = 0b00001000;
export const ContentReset = 0b00010000;
export const Callback = 0b00100000;
export const Err = 0b01000000;
export const Ref = 0b10000000;