Skip to content

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 12, 2017

This doesn't do much in terms of bundle size but makes the code clearer IMO.
These constructors always have the same arguments so we just generate them now.

Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, 👍

@gaearon gaearon merged commit 73265fc into facebook:master Dec 12, 2017
@gaearon gaearon deleted the synth-simpler branch December 12, 2017 16:45
yenshih pushed a commit to yenshih/react that referenced this pull request Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants