Skip to content

Remove IE8 event.target polyfill via srcElement #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2018
Merged

Remove IE8 event.target polyfill via srcElement #11515

merged 1 commit into from
Jan 5, 2018
+1 −187

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 10, 2017

Just noticed it seems like srcElement is IE8-only.
Not actually sure we want to do this until we remove the attachEvent() call in EventListener.

nhunzaker
nhunzaker approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 👍

@nhunzaker
Copy link
Contributor

nhunzaker commented Nov 21, 2017

Not actually sure we want to do this until we remove the attachEvent() call in EventListener.

@gaearon Are we able to just remove EventListener.listen and EventListener.capture in ReactEventListener?

https://github.com/facebook/react/blob/master/packages/react-dom/src/events/ReactDOMEventListener.js#L123-L153

I'm personally motivated to get rid of it from some investigation in #11550. The return signature isn't getting used in React at all.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 21, 2017

Are we able to just remove EventListener.listen and EventListener.capture in ReactEventListener?

Yes, should be fine.

@nhunzaker nhunzaker mentioned this pull request Nov 22, 2017
Closed
@gaearon gaearon merged commit fe10b8d into facebook:master Jan 5, 2018
yenshih pushed a commit to yenshih/react that referenced this pull request Jan 6, 2018
@gaearon @yenshih
Remove IE8 event.target polyfill via srcElement (facebook#11515)
4325b65
ManasJayanth pushed a commit to ManasJayanth/react that referenced this pull request Jan 12, 2018
@gaearon @ManasJayanth
Remove IE8 event.target polyfill via srcElement (facebook#11515)
35d9523
@gaearon gaearon mentioned this pull request Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nhunzaker nhunzaker nhunzaker approved these changes

@aweary aweary aweary approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaearon @nhunzaker @aweary @facebook-github-bot