Update font scale on Android when recreating RootView #52595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78323174 |
facebook-github-bot
added
fb-exported
p: Software Mansion
j-piasecki
force-pushed
the
export-D78323174
branch
from
4147906 to
ea5b557
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jul 18, 2025
Summary: Changelog: [ANDROID][FIXED] Update font scale when recreating `RootView` At the moment `enableFontScaleChangesUpdatingLayout` flag only works when the activity is configured to handle font scale changes by itself (`configChanges="fontScale"` in the manifest). When that configuration is missing, the OS handles the font scale changes by recreating the activity, but in this case the path responsible for updating internally kept font size isn't executed. This diff updates the RootView, so that the display metrics are also updated when it's created. Alternative approach would be to do that on the Activity, but that assumes usage of `ReactActivity`. Reviewed By: NickGerleman Differential Revision: D78323174
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78323174 |
Summary: Changelog: [ANDROID][FIXED] Update font scale when recreating `RootView` At the moment `enableFontScaleChangesUpdatingLayout` flag only works when the activity is configured to handle font scale changes by itself (`configChanges="fontScale"` in the manifest). When that configuration is missing, the OS handles the font scale changes by recreating the activity, but in this case the path responsible for updating internally kept font size isn't executed. This diff updates the RootView, so that the display metrics are also updated when it's created. Alternative approach would be to do that on the Activity, but that assumes usage of `ReactActivity`. Reviewed By: NickGerleman Differential Revision: D78323174
j-piasecki
force-pushed
the
export-D78323174
branch
from
ea5b557 to
cd052e4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78323174 |
Contributor
|
This pull request has been merged in 5cda306. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 5cda306 When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebook#52595 Changelog: [ANDROID][FIXED] Update font scale when recreating `RootView` At the moment `enableFontScaleChangesUpdatingLayout` flag only works when the activity is configured to handle font scale changes by itself (`configChanges="fontScale"` in the manifest). When that configuration is missing, the OS handles the font scale changes by recreating the activity, but in this case the path responsible for updating internally kept font size isn't executed. This diff updates the RootView, so that the display metrics are also updated when it's created. Alternative approach would be to do that on the Activity, but that assumes usage of `ReactActivity`. Reviewed By: NickGerleman Differential Revision: D78323174 fbshipit-source-id: e48583091767497b5dfd4f2d938329530de4068d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [ANDROID][FIXED] Update font scale when recreating
RootViewAt the moment
enableFontScaleChangesUpdatingLayoutflag only works when the activity is configured to handle font scale changes by itself (configChanges="fontScale"in the manifest).When that configuration is missing, the OS handles the font scale changes by recreating the activity, but in this case the path responsible for updating internally kept font size isn't executed.
This diff updates the RootView, so that the display metrics are also updated when it's created. Alternative approach would be to do that on the Activity, but that assumes usage of
ReactActivity.Differential Revision: D78323174