Convert TextLayoutManager to Kotlin and Make Internal #51966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76444163 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76444163 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51966 This starts off mechanically, but needed a couple changes: 1. Some null handling changes to `TextTransform` internals 2. We type MapBuffer keys as `Int` instead of `Short`, because Kotlin does not allow the implicit widening cast that Java does. I also made these internal 3. Some shifts around casting 4. Mark TextLayoutManager internal, and remove usages of `UnstableReactNativeAPI` I verified that there were no usages of the Java side of TextLayoutManager throughout `react-native-libraries`, so marking TextLayoutManager internal is unlikely to break 3p libraries. Changelog: [Android][Breaking] - Make Java Side TextLayoutManager Internal Differential Revision: D76444163
NickGerleman
force-pushed
the
export-D76444163
branch
from
544a356 to
3899ead
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76444163 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51966 This starts off mechanically, but needed a couple changes: 1. Some null handling changes to `TextTransform` internals 2. We type MapBuffer keys as `Int` instead of `Short`, because Kotlin does not allow the implicit widening cast that Java does. I also made these internal 3. Some shifts around casting 4. Mark TextLayoutManager internal, and remove usages of `UnstableReactNativeAPI` I verified that there were no usages of the Java side of TextLayoutManager throughout `react-native-libraries`, so marking TextLayoutManager internal is unlikely to break 3p libraries. Changelog: [Android][Breaking] - Make Java Side TextLayoutManager Internal Differential Revision: D76444163
NickGerleman
force-pushed
the
export-D76444163
branch
from
3899ead to
9e6b2cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76444163 |
NickGerleman
force-pushed
the
export-D76444163
branch
from
9e6b2cd to
2003d53
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: facebook#51966 This starts off mechanically, but needed a couple changes: 1. Some null handling changes to `TextTransform` internals 2. We type MapBuffer keys as `Int` instead of `Short`, because Kotlin does not allow the implicit widening cast that Java does. I also made these internal 3. Some shifts around casting 4. Mark TextLayoutManager internal, and remove usages of `UnstableReactNativeAPI` I verified that there were no usages of the Java side of TextLayoutManager throughout `react-native-libraries`, so marking TextLayoutManager internal is unlikely to break 3p libraries. Changelog: [Android][Breaking] - Make Java Side TextLayoutManager Internal Differential Revision: D76444163
Summary: Pull Request resolved: facebook#51966 This starts off mechanically, but needed a couple changes: 1. Some null handling changes to `TextTransform` internals 2. We type MapBuffer keys as `Int` instead of `Short`, because Kotlin does not allow the implicit widening cast that Java does. I also made these internal 3. Some shifts around casting 4. Mark TextLayoutManager internal, and remove usages of `UnstableReactNativeAPI` I verified that there were no usages of the Java side of TextLayoutManager throughout `react-native-libraries`, so marking TextLayoutManager internal is unlikely to break 3p libraries. Changelog: [Android][Breaking] - Make Java Side TextLayoutManager Internal Differential Revision: D76444163
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76444163 |
NickGerleman
force-pushed
the
export-D76444163
branch
from
2003d53 to
9081c4c
Compare
Collaborator
|
This pull request was successfully merged by @NickGerleman in e82a677 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in e82a677. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This starts off mechanically, but needed a couple changes:
TextTransforminternalsIntinstead ofShort, because Kotlin does not allow the implicit widening cast that Java does. I also made these internalUnstableReactNativeAPII verified that there were no usages of the Java side of TextLayoutManager throughout
react-native-libraries, so marking TextLayoutManager internal is unlikely to break 3p libraries.Changelog:
[Android][Breaking] - Make Java Side TextLayoutManager Internal
Differential Revision: D76444163