(cherry-pick) Move RefreshControlMock into Jest preset files (#51530) #51942
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#51530 Alternative to facebook#50784. `__mocks__` (and other underscored dirs) are correctly excluded from our npm package via `package.json#files`. But in this instance, this is a source file for the `jest/` directory (Jest preset within `react-native`), and should be included — fix by relocating. Changelog: [General][Fixed] - Fix missing RefreshControlMock source in Jest preset Reviewed By: rshest Differential Revision: D75215731 fbshipit-source-id: 1240344c4236288f31b16513f4df16766ad1e571 # Conflicts: # packages/react-native/jest/setup.js
facebook-github-bot
added
the
CLA Signed
Contributor
|
Closing as #51530 has already been picked on the release branch |
|
@cortinico In which release and by when the fix will be coming ? |
Contributor
|
It's on the 0.80 release branch: https://github.com/facebook/react-native/commits/0.80-stable/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick from: #51530
Summary:
Alternative to #50784.
__mocks__(and other underscored dirs) are correctly excluded from our npm package viapackage.json#files. But in this instance, this is a source file for thejest/directory (Jest preset withinreact-native), and should be included — fix by relocating.Changelog:
[General][Fixed] - Fix missing RefreshControlMock source in Jest preset
Reviewed By: rshest
Differential Revision: D75215731
fbshipit-source-id: 1240344c4236288f31b16513f4df16766ad1e571
Conflicts:
packages/react-native/jest/setup.js
Summary:
Changelog:
Test Plan: