Skip to content

Rename root -> view in ViewManager parameters #51755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 1 commit into from
Closed

Rename root -> view in ViewManager parameters #51755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ protected void onAfterUpdateTransaction(@NonNull T view) {}
*
* <p>TODO T7247021: Replace updateExtraData with generic update props mechanism after D2086999
*/
public abstract void updateExtraData(@NonNull T root, Object extraData);
public abstract void updateExtraData(@NonNull T view, Object extraData);

/**
* Subclasses may use this method to receive events/commands directly from JS through the {@link
Expand All @@ -323,24 +323,24 @@ protected void onAfterUpdateTransaction(@NonNull T view) {}
*
* <p>This method is deprecated use {@link #receiveCommand(View, String, ReadableArray)} instead.
*
* @param root View instance that should receive the command
* @param view View instance that should receive the command
* @param commandId code of the command
* @param args optional arguments for the command
*/
@Deprecated
public void receiveCommand(@NonNull T root, int commandId, @Nullable ReadableArray args) {}
public void receiveCommand(@NonNull T view, int commandId, @Nullable ReadableArray args) {}

/**
* Subclasses may use this method to receive events/commands directly from JS through the {@link
* UIManager}. Good example of such a command would be {@code scrollTo} request with coordinates
* for a {@link ReactScrollView} instance.
*
* @param root View instance that should receive the command
* @param view View instance that should receive the command
* @param commandId code of the command
* @param args optional arguments for the command
*/
public void receiveCommand(@NonNull T root, String commandId, @Nullable ReadableArray args) {
getOrCreateViewManagerDelegate().receiveCommand(root, commandId, args);
public void receiveCommand(@NonNull T view, String commandId, @Nullable ReadableArray args) {
getOrCreateViewManagerDelegate().receiveCommand(view, commandId, args);
}

/**
Expand Down
Loading