Skip to content

RN: Default featureflags Script to Update #51708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yungsters wants to merge 2 commits into from
Closed

RN: Default featureflags Script to Update #51708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86bc3a6
RN: Fix Typing for Non-Boolean Feature Flags (#51707)
yungsters May 30, 2025
1aa6bec
RN: Default `featureflags` Script to Update
yungsters May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/react-native/scripts/featureflags/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ if (require.main === module) {
command = 'verify-unchanged';
} else if (process.argv.includes('--print')) {
command = 'print';
} else if (process.argv.includes('--help')) {
command = 'help';
} else {
console.log('Defaulting to `--update`. See all options using `--help`.');
command = 'update';
}

switch (command) {
Expand All @@ -31,10 +36,12 @@ if (require.main === module) {
case 'print':
require('./print').default(process.argv.includes('--json'));
break;
default:
console.error(
'Usage: node featureflags.js [--update|--verify-unchanged|--print]',
case 'help':
console.log(
'Usage: node featureflags.js [--update|--verify-unchanged|--print|--help]',
);
process.exit(1);
break;
default:
throw new Error('Unexpected script execution.');
}
}
2 changes: 1 addition & 1 deletion ...ts/featureflags/templates/common-cxx/ReactNativeFeatureFlagsDynamicProvider.h-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import type {
import {DO_NOT_MODIFY_COMMENT, getCxxTypeFromDefaultValue} from '../../utils';
import signedsource from 'signedsource';

function getFollyDynamicAccessor(config: CommonFeatureFlagConfig): string {
function getFollyDynamicAccessor(config: CommonFeatureFlagConfig<>): string {
switch (typeof config.defaultValue) {
case 'boolean':
return 'getBool';
Expand Down
26 changes: 15 additions & 11 deletions packages/react-native/scripts/featureflags/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,30 +28,34 @@ export type OSSReleaseStageValue =
| 'canary'
| 'stable';

export type CommonFeatureFlagConfig = $ReadOnly<{
defaultValue: FeatureFlagValue,
metadata: FeatureFlagMetadata,
export type CommonFeatureFlagConfig<
TValue: FeatureFlagValue = FeatureFlagValue,
> = $ReadOnly<{
defaultValue: TValue,
metadata: FeatureFlagMetadata<TValue>,
ossReleaseStage: OSSReleaseStageValue,
// Indicates if this API should only be defined in JavaScript, only to
// preserve backwards compatibility with existing native code temporarily.
skipNativeAPI?: true,
}>;

export type CommonFeatureFlagList = $ReadOnly<{
[flagName: string]: CommonFeatureFlagConfig,
[flagName: string]: CommonFeatureFlagConfig<>,
}>;

export type JsOnlyFeatureFlagConfig = $ReadOnly<{
defaultValue: FeatureFlagValue,
metadata: FeatureFlagMetadata,
export type JsOnlyFeatureFlagConfig<
TValue: FeatureFlagValue = FeatureFlagValue,
> = $ReadOnly<{
defaultValue: TValue,
metadata: FeatureFlagMetadata<TValue>,
ossReleaseStage: OSSReleaseStageValue,
}>;

export type JsOnlyFeatureFlagList = $ReadOnly<{
[flagName: string]: JsOnlyFeatureFlagConfig,
[flagName: string]: JsOnlyFeatureFlagConfig<>,
}>;

export type FeatureFlagMetadata =
export type FeatureFlagMetadata<TValue: FeatureFlagValue = FeatureFlagValue> =
| $ReadOnly<{
purpose: 'experimentation',
/**
Expand All @@ -60,12 +64,12 @@ export type FeatureFlagMetadata =
*/
dateAdded: string,
description: string,
expectedReleaseValue: boolean,
expectedReleaseValue: TValue,
}>
| $ReadOnly<{
purpose: 'operational' | 'release',
description: string,
expectedReleaseValue: boolean,
expectedReleaseValue: TValue,
}>;

export type GeneratorConfig = $ReadOnly<{
Expand Down
Loading