Skip to content

Move default trackingName as undefined to RCTNetworking #51703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
+8 −8
Closed

Move default trackingName as undefined to RCTNetworking #51703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Network/RCTNetworking.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const RCTNetworking = {

sendRequest(
method: string,
trackingName: ?string,
trackingName: string | void,
url: string,
headers: Object,
data: RequestBody,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Network/RCTNetworking.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const RCTNetworking = {

sendRequest(
method: string,
trackingName: ?string,
trackingName: string | void,
url: string,
headers: {...},
data: RequestBody,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Network/RCTNetworking.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ declare const RCTNetworking: interface {

sendRequest(
method: string,
trackingName: ?string,
trackingName: string | void,
url: string,
headers: {...},
data: RequestBody,
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/Libraries/Network/XMLHttpRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class XMLHttpRequest extends EventTarget {
_sent: boolean;
_url: ?string = null;
_timedOut: boolean = false;
_trackingName: string | void = undefined;
_trackingName: ?string;
_incrementalEvents: boolean = false;
_startTime: ?number = null;
_performanceLogger: IPerformanceLogger = GlobalPerformanceLogger;
Expand Down Expand Up @@ -534,7 +534,7 @@ class XMLHttpRequest extends EventTarget {
/**
* Custom extension for tracking origins of request.
*/
setTrackingName(trackingName: string | void): XMLHttpRequest {
setTrackingName(trackingName: ?string): XMLHttpRequest {
this._trackingName = trackingName;
return this;
}
Expand Down Expand Up @@ -632,7 +632,7 @@ class XMLHttpRequest extends EventTarget {
);
RCTNetworking.sendRequest(
this._method,
this._trackingName,
this._trackingName ?? undefined,
this._url,
this._headers,
data,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5916,7 +5916,7 @@ exports[`public API should not change unintentionally Libraries/Network/RCTNetwo
): EventSubscription,
sendRequest(
method: string,
trackingName: ?string,
trackingName: string | void,
url: string,
headers: { ... },
data: RequestBody,
Expand Down Expand Up @@ -6010,7 +6010,7 @@ declare class XMLHttpRequest extends EventTarget {
getAllResponseHeaders(): ?string;
getResponseHeader(header: string): ?string;
setRequestHeader(header: string, value: any): void;
setTrackingName(trackingName: string | void): XMLHttpRequest;
setTrackingName(trackingName: ?string): XMLHttpRequest;
setPerformanceLogger(performanceLogger: IPerformanceLogger): XMLHttpRequest;
open(method: string, url: string, async: ?boolean): void;
send(data: any): void;
Expand Down
Loading