RN: Refactor Jest Default Mocks #51669
Closed
+951
−599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
yungsters
force-pushed
the
export-D75575421
branch
from
0c7c882 to
665bc30
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
force-pushed
the
export-D75575421
branch
from
665bc30 to
781e768
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
yungsters
force-pushed
the
export-D75575421
branch
from
781e768 to
f410098
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
force-pushed
the
export-D75575421
branch
from
f410098 to
b964f59
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
force-pushed
the
export-D75575421
branch
from
b964f59 to
f5dbbf0
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
yungsters
force-pushed
the
export-D75575421
branch
from
f5dbbf0 to
2b159ed
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
Summary: Pull Request resolved: facebook#51669 Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: facebook#51669 Refactors the default mocks initialized in `packages/react-native/jest/setup.js` so that each mock is defined in its own file. This provides several benefits, including: - The ability to use `import` statements without worrying about eager initialization of dependencies before `globals` is setup. - The ability to verify mocks export the same types as the actual module, using a new Flow-typed `mock` helper function. - The ergonomic of implementing mocks with more complex logic, without having to split them out into a separate module (e.g. `mockModal`, `mockScrollView`). As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes. Changelog: [General][Changed] - Improved default mocking for Jest unit tests. Differential Revision: D75575421
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75575421 |
yungsters
force-pushed
the
export-D75575421
branch
from
2b159ed to
31e8ea8
Compare
Contributor
|
This pull request has been merged in 1fd9508. |
Collaborator
|
This pull request was successfully merged by @yungsters in 1fd9508 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors the default mocks initialized in
packages/react-native/jest/setup.jsso that each mock is defined in its own file.This provides several benefits, including:
importstatements without worrying about eager initialization of dependencies beforeglobalsis setup.mockhelper function.mockModal,mockScrollView).As part of this migration, I also fixed any minor discrepancies to match the actual type definition. For more involved discrepancies (e.g. missing methods), I added type suppressions for now to minimize breaking changes.
Changelog:
[General][Changed] - Improved default mocking for Jest unit tests.
Differential Revision: D75575421