Remove native animation fabric sync in JS and infinite animation loop workaround #51264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74198568 |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 12, 2025
… workaround (facebook#51264) Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Differential Revision: D74198568
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74198568 |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 12, 2025
… workaround (facebook#51264) Summary: Pull Request resolved: facebook#51264 ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Differential Revision: D74198568
zeyap
force-pushed
the
export-D74198568
branch
2 times, most recently
from
e59c1a0 to
6778936
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 12, 2025
… workaround (facebook#51264) Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Differential Revision: D74198568
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74198568 |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 12, 2025
… workaround (facebook#51264) Summary: Pull Request resolved: facebook#51264 ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Differential Revision: D74198568
zeyap
force-pushed
the
export-D74198568
branch
2 times, most recently
from
962e220 to
000a79d
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 13, 2025
… workaround (facebook#51264) Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Reviewed By: lenaic Differential Revision: D74198568
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74198568 |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 13, 2025
… workaround (facebook#51264) Summary: Pull Request resolved: facebook#51264 ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Reviewed By: lenaic Differential Revision: D74198568
zeyap
force-pushed
the
export-D74198568
branch
2 times, most recently
from
07c78a0 to
26b1de2
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 14, 2025
… workaround (facebook#51264) Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Reviewed By: lenaic Differential Revision: D74198568
… workaround (facebook#51264) Summary: Pull Request resolved: facebook#51264 ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Reviewed By: lenaic Differential Revision: D74198568
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74198568 |
Contributor
|
This pull request has been merged in 2d7342f. |
Collaborator
|
This pull request was successfully merged by @zeyap in 2d7342f When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by dc737cb. |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Jun 2, 2025
…d infinite animation loop workaround Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Differential Revision: D75789100
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
…te animation loop workaround Summary: ## Changelog: [General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose Reviewed By: sammy-SC Differential Revision: D75789100 fbshipit-source-id: 966e2b187f43e8743ccbf7ba97b8e8a27273fe0c
sxsing
pushed a commit
to sxsing/react-native
that referenced
this pull request
Jun 10, 2025
…c in JS and infinite animation loop workaround" Summary: Reverting for the same reason as D75108344. Original commit changeset: 966e2b187f43 Original Phabricator Diff: D75789100 Reviewed By: zijunl Differential Revision: D76352826
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…and infinite animation loop workaround" (#51933) Summary: ## Changelog: [General] [Changed] - Revert a previous change that caused UI regression Pull Request resolved: #51933 Reverting for the same reason as D75108344. Original commit changeset: 966e2b187f43 Original Phabricator Diff: D75789100 Reviewed By: zijunl Differential Revision: D76352826 fbshipit-source-id: bfae95e2fe66b19b9d615eb5290c0ca5964088e3
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Jun 16, 2025
Summary: ## Changelog: [Internal] [Changed] - Gate logic to remove js sync at end of native animation loop because facebook#51264 is causing regression in some cases, and was recently reverted again in facebook#51933 . Using an extra feature flag to gate this potential optimization Differential Revision: D76759441
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Jun 17, 2025
…k#52068) Summary: Pull Request resolved: facebook#52068 ## Changelog: [Internal] [Changed] - Gate logic to remove js sync at end of native animation loop because facebook#51264 is causing regression in some cases, and was recently reverted again in facebook#51933 . Using an extra feature flag to gate this potential optimization Reviewed By: lenaic Differential Revision: D76759441
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Jun 17, 2025
…k#52068) Summary: Pull Request resolved: facebook#52068 ## Changelog: [Internal] [Changed] - Gate logic to remove js sync at end of native animation loop because facebook#51264 is causing regression in some cases, and was recently reverted again in facebook#51933 . Using an extra feature flag to gate this potential optimization Reviewed By: lenaic Differential Revision: D76759441
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: #52068 ## Changelog: [Internal] [Changed] - Gate logic to remove js sync at end of native animation loop because #51264 is causing regression in some cases, and was recently reverted again in #51933 . Using an extra feature flag to gate this potential optimization Reviewed By: lenaic Differential Revision: D76759441 fbshipit-source-id: 6950ab746b02af6e0b710ded0ddb6993673e5212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Changed] - Remove native animation fabric sync in JS and infinite animation loop workaround, when cxxNativeAnimated is enabled
when cxxNativeAnimated is enabled, we'll sync native animation props back to Fabric in native, when that happens we can remove the code in JS for same purpose
Differential Revision: D74198568