Remove .npmignore files from other packages, add lint check

.github/actions/lint/action.yml

@@ -29,6 +29,9 @@ runs:
     - name: Lint java
       shell: bash
       run: ./.github/workflow-scripts/exec_swallow_error.sh yarn lint-java --check
+    - name: Lint file structure
+      shell: bash
+      run: ./.github/workflow-scripts/lint_files.sh
     - name: Verify not committing repo after running build
       shell: bash
       run: yarn run build --check

.github/workflow-scripts/lint_files.sh

@@ -0,0 +1,12 @@
+#!/bin/bash
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+set -e
+
+if git ls-files | grep -E '\.npmignore$'; then
+  echo "Error: Found unexpected .npmignore file(s). Please use package.json#files instead."
+  exit 1
+fi

packages/assets/package.json

@@ -18,5 +18,14 @@
   "bugs": "https://github.com/facebook/react-native/issues",
   "engines": {
     "node": ">=18"
-  }
+  },
+  "files": [
+    "path-support.js",
+    "registry.js",
+    "README.md",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**"
+  ]
 }

packages/eslint-plugin-react-native/utils.js

@@ -61,7 +61,7 @@ const publicAPIMapping = {
   'Libraries/Utilities/BackHandler': 'BackHandler',
   'Libraries/Components/Clipboard/Clipboard': 'Clipboard',
   'Libraries/Utilities/DeviceInfo': 'DeviceInfo',
-  'src/private/devmenu/DevMenu': 'DevMenu',
+  'src/private/devsupport/devmenu/DevMenu': 'DevMenu',
   'Libraries/Utilities/DevSettings': 'DevSettings',
   'Libraries/Utilities/Dimensions': 'Dimensions',
   'Libraries/Animated/Easing': 'Easing',

packages/normalize-color/package.json

@@ -15,5 +15,13 @@
     "normalize-colors",
     "react-native"
   ],
-  "bugs": "https://github.com/facebook/react-native/issues"
+  "bugs": "https://github.com/facebook/react-native/issues",
+  "files": [
+    "index.js",
+    "README.md",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**"
+  ]
 }

packages/polyfills/package.json

@@ -19,5 +19,15 @@
   "bugs": "https://github.com/facebook/react-native/issues",
   "engines": {
     "node": ">=18"
-  }
+  },
+  "files": [
+    "console.js",
+    "error-guard.js",
+    "index.js",
+    "README.md",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**"
+  ]
 }

packages/react-native-babel-preset/package.json

@@ -2,7 +2,6 @@
   "name": "@react-native/babel-preset",
   "version": "0.80.0-main",
   "description": "Babel preset for React Native applications",
-  "main": "src/index.js",
   "repository": {
     "type": "git",
     "url": "git+ssh://[email protected]/facebook/react-native.git"
@@ -13,6 +12,18 @@
     "react-native"
   ],
   "license": "MIT",
+  "engines": {
+    "node": ">=18"
+  },
+  "main": "src/index.js",
+  "files": [
+    "src",
+    "README.md",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**"
+  ],
   "dependencies": {
     "@babel/core": "^7.25.2",
     "@babel/plugin-proposal-export-default-from": "^7.24.7",
@@ -62,8 +73,5 @@
   },
   "peerDependencies": {
     "@babel/core": "*"
-  },
-  "engines": {
-    "node": ">=18"
   }
 }

packages/react-native-babel-transformer/package.json

@@ -2,7 +2,6 @@
   "name": "@react-native/metro-babel-transformer",
   "version": "0.80.0-main",
   "description": "Babel transformer for React Native applications.",
-  "main": "src/index.js",
   "repository": {
     "type": "git",
     "url": "git+ssh://[email protected]/facebook/react-native.git",
@@ -14,6 +13,18 @@
     "metro"
   ],
   "license": "MIT",
+  "engines": {
+    "node": ">=18"
+  },
+  "main": "src/index.js",
+  "files": [
+    "src",
+    "README.md",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**"
+  ],
   "dependencies": {
     "@babel/core": "^7.25.2",
     "@react-native/babel-preset": "0.80.0-main",
@@ -22,8 +33,5 @@
   },
   "peerDependencies": {
     "@babel/core": "*"
-  },
-  "engines": {
-    "node": ">=18"
   }
 }

packages/react-native/Libraries/Core/setUpReactDevTools.js

@@ -10,8 +10,8 @@
 
 'use strict';
 
-import type {Domain} from '../../src/private/debugging/setUpFuseboxReactDevToolsDispatcher';
-import type {Spec as NativeReactDevToolsRuntimeSettingsModuleSpec} from '../../src/private/fusebox/specs/NativeReactDevToolsRuntimeSettingsModule';
+import type {Domain} from '../../src/private/devsupport/rndevtools/setUpFuseboxReactDevToolsDispatcher';
+import type {Spec as NativeReactDevToolsRuntimeSettingsModuleSpec} from '../../src/private/devsupport/rndevtools/specs/NativeReactDevToolsRuntimeSettingsModule';
 
 if (__DEV__) {
   if (typeof global.queueMicrotask !== 'function') {
@@ -31,18 +31,18 @@ if (__DEV__) {
 
 if (__DEV__) {
   // Register dispatcher on global, which can be used later by Chrome DevTools frontend
-  require('../../src/private/debugging/setUpFuseboxReactDevToolsDispatcher');
+  require('../../src/private/devsupport/rndevtools/setUpFuseboxReactDevToolsDispatcher');
   const {
     initialize,
     connectToDevTools,
     connectWithCustomMessagingProtocol,
   } = require('react-devtools-core');
 
-  const reactDevToolsSettingsManager = require('../../src/private/debugging/ReactDevToolsSettingsManager');
+  const reactDevToolsSettingsManager = require('../../src/private/devsupport/rndevtools/ReactDevToolsSettingsManager');
   const serializedHookSettings =
     reactDevToolsSettingsManager.getGlobalHookSettings();
   const maybeReactDevToolsRuntimeSettingsModuleModule =
-    require('../../src/private/fusebox/specs/NativeReactDevToolsRuntimeSettingsModule').default;
+    require('../../src/private/devsupport/rndevtools/specs/NativeReactDevToolsRuntimeSettingsModule').default;
 
   let hookSettings = null;
   if (serializedHookSettings != null) {

packages/react-native/Libraries/LogBox/Data/LogBoxData.js

@@ -18,7 +18,7 @@ import type {
   Message,
 } from './parseLogBoxLog';
 
-import DebuggerSessionObserver from '../../../src/private/debugging/FuseboxSessionObserver';
+import DebuggerSessionObserver from '../../../src/private/devsupport/rndevtools/FuseboxSessionObserver';
 import parseErrorStack from '../../Core/Devtools/parseErrorStack';
 import NativeDevSettings from '../../NativeModules/specs/NativeDevSettings';
 import NativeLogBox from '../../NativeModules/specs/NativeLogBox';

packages/react-native/Libraries/NativeModules/specs/NativeDevMenu.js

@@ -8,6 +8,6 @@
  * @format
  */
 
-export * from '../../../src/private/specs_DEPRECATED/modules/NativeDevMenu';
-import NativeDevMenu from '../../../src/private/specs_DEPRECATED/modules/NativeDevMenu';
+export * from '../../../src/private/devsupport/devmenu/specs/NativeDevMenu';
+import NativeDevMenu from '../../../src/private/devsupport/devmenu/specs/NativeDevMenu';
 export default NativeDevMenu;

packages/react-native/Libraries/ReactNative/AppContainer-dev.js

@@ -53,7 +53,8 @@ const InspectorDeferred = ({
 }: InspectorDeferredProps) => {
   // D39382967 adds a require cycle: InitializeCore -> AppContainer -> Inspector -> InspectorPanel -> ScrollView -> InitializeCore
   // We can't remove it yet, fallback to dynamic require for now. This is the only reason why this logic is in a separate function.
-  const Inspector = require('../../src/private/inspector/Inspector').default;
+  const Inspector =
+    require('../../src/private/devsupport/devmenu/elementinspector/Inspector').default;
 
   return (
     <Inspector
@@ -74,7 +75,7 @@ const ReactDevToolsOverlayDeferred = ({
   reactDevToolsAgent,
 }: ReactDevToolsOverlayDeferredProps) => {
   const ReactDevToolsOverlay =
-    require('../../src/private/inspector/ReactDevToolsOverlay').default;
+    require('../../src/private/devsupport/devmenu/elementinspector/ReactDevToolsOverlay').default;
 
   return (
     <ReactDevToolsOverlay

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

@@ -5784,7 +5784,7 @@ declare export function isIgnored(value: mixed): boolean;
 `;
 
 exports[`public API should not change unintentionally Libraries/NativeModules/specs/NativeDevMenu.js 1`] = `
-"export * from \\"../../../src/private/specs_DEPRECATED/modules/NativeDevMenu\\";
+"export * from \\"../../../src/private/devsupport/devmenu/specs/NativeDevMenu\\";
 declare export default typeof NativeDevMenu;
 "
 `;
@@ -9070,7 +9070,7 @@ export { default as codegenNativeCommands } from \\"./Libraries/Utilities/codege
 export { default as DeviceEventEmitter } from \\"./Libraries/EventEmitter/RCTDeviceEventEmitter\\";
 export type { DeviceInfoConstants } from \\"./Libraries/Utilities/DeviceInfo\\";
 export { default as DeviceInfo } from \\"./Libraries/Utilities/DeviceInfo\\";
-export { default as DevMenu } from \\"./src/private/devmenu/DevMenu\\";
+export { default as DevMenu } from \\"./src/private/devsupport/devmenu/DevMenu\\";
 export { default as DevSettings } from \\"./Libraries/Utilities/DevSettings\\";
 export type {
   DimensionsPayload,

packages/react-native/index.js

@@ -183,7 +183,7 @@ module.exports = {
     return require('./Libraries/Utilities/DeviceInfo').default;
   },
   get DevMenu() {
-    return require('./src/private/devmenu/DevMenu').default;
+    return require('./src/private/devsupport/devmenu/DevMenu').default;
   },
   get DevSettings() {
     return require('./Libraries/Utilities/DevSettings').default;

packages/react-native/index.js.flow

@@ -248,7 +248,7 @@ export {default as DeviceEventEmitter} from './Libraries/EventEmitter/RCTDeviceE
 export type {DeviceInfoConstants} from './Libraries/Utilities/DeviceInfo';
 export {default as DeviceInfo} from './Libraries/Utilities/DeviceInfo';
 
-export {default as DevMenu} from './src/private/devmenu/DevMenu';
+export {default as DevMenu} from './src/private/devsupport/devmenu/DevMenu';
 export {default as DevSettings} from './Libraries/Utilities/DevSettings';
 
 export type {

packages/react-native/package.json

@@ -49,48 +49,60 @@
     "React",
     "!React/Fabric/RCTThirdPartyFabricComponentsProvider.*",
     "ReactAndroid",
+    "!ReactAndroid/.cxx",
+    "!ReactAndroid/build",
+    "!ReactAndroid/external-artifacts/artifacts",
+    "!ReactAndroid/external-artifacts/build",
+    "!ReactAndroid/hermes-engine/.cxx",
+    "!ReactAndroid/hermes-engine/build",
+    "!ReactAndroid/src/main/third-party",
+    "!ReactAndroid/src/test",
     "ReactApple",
     "ReactCommon",
     "README.md",
     "rn-get-polyfills.js",
+    "scripts/bundle.js",
+    "scripts/cocoapods",
+    "scripts/codegen",
     "scripts/compose-source-maps.js",
     "scripts/find-node-for-xcode.sh",
-    "scripts/bundle.js",
     "scripts/generate-codegen-artifacts.js",
     "scripts/generate-provider-cli.js",
     "scripts/generate-specs-cli.js",
-    "scripts/codegen",
-    "!scripts/codegen/__tests__",
-    "!scripts/codegen/__test_fixtures__",
     "scripts/hermes/hermes-utils.js",
     "scripts/hermes/prepare-hermes-for-build.js",
     "scripts/ios-configure-glog.sh",
-    "scripts/xcode/ccache-clang++.sh",
-    "scripts/xcode/ccache-clang.sh",
-    "scripts/xcode/ccache.conf",
-    "scripts/xcode/with-environment.sh",
     "scripts/native_modules.rb",
     "scripts/node-binary.sh",
-    "scripts/packager.sh",
     "scripts/packager-reporter.js",
+    "scripts/packager.sh",
     "scripts/react_native_pods_utils/script_phases.rb",
     "scripts/react_native_pods_utils/script_phases.sh",
     "scripts/react_native_pods.rb",
-    "scripts/cocoapods",
-    "!scripts/cocoapods/__tests__",
     "scripts/react-native-xcode.sh",
+    "scripts/xcode/ccache-clang.sh",
+    "scripts/xcode/ccache-clang++.sh",
+    "scripts/xcode/ccache.conf",
+    "scripts/xcode/with-environment.sh",
     "sdks/.hermesversion",
     "sdks/hermes-engine",
     "sdks/hermesc",
     "settings.gradle.kts",
     "src",
+    "!src/private/testing",
     "template.config.js",
     "template",
     "!template/node_modules",
     "!template/package-lock.json",
     "!template/yarn.lock",
     "third-party-podspecs",
-    "types"
+    "types",
+    "!**/__docs__/**",
+    "!**/__fixtures__/**",
+    "!**/__flowtests__/**",
+    "!**/__mocks__/**",
+    "!**/__tests__/**",
+    "!**/__typetests__/**"
   ],
   "scripts": {
     "prepack": "node ./scripts/prepack.js",