Use source shadow node state on clone #50773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 15, 2025 08:01
Differential Revision: D73038437
Differential Revision: D73067007
Summary: With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases. This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit. Changelog: [Internal] Reviewed By: rshest, cipolleschi Differential Revision: D72315898
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72315898 |
Contributor
|
This pull request has been merged in 96939f1. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50773 With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases. This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit. Changelog: [Internal] Reviewed By: rshest, cipolleschi Differential Revision: D72315898 fbshipit-source-id: 5e14d03681dd1cc5686a649caa2e8c3685042cfa
This was referenced Apr 25, 2025
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: facebook#50773 With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases. This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit. Changelog: [Internal] Reviewed By: rshest, cipolleschi Differential Revision: D72315898 fbshipit-source-id: 5e14d03681dd1cc5686a649caa2e8c3685042cfa
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
May 20, 2025
* Add feature flag for using shadow node state on clone Copy of commit: b962646 PR: facebook#50751 wasn't cherry-pickable * Use source shadow node state on clone (facebook#50773) Summary: Pull Request resolved: facebook#50773 With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases. This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit. Changelog: [Internal] Reviewed By: rshest, cipolleschi Differential Revision: D72315898 fbshipit-source-id: 5e14d03681dd1cc5686a649caa2e8c3685042cfa --------- Co-authored-by: Nick Lefever <[email protected]>
bdbaraban
pushed a commit
to discord/react-native
that referenced
this pull request
May 22, 2025
* Add feature flag for using shadow node state on clone Copy of commit: b962646 PR: facebook#50751 wasn't cherry-pickable * Use source shadow node state on clone (facebook#50773) Summary: Pull Request resolved: facebook#50773 With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases. This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit. Changelog: [Internal] Reviewed By: rshest, cipolleschi Differential Revision: D72315898 fbshipit-source-id: 5e14d03681dd1cc5686a649caa2e8c3685042cfa --------- Co-authored-by: Nick Lefever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With shadow node syncing enabled by default, whenever a shadow node has to be cloned, we can be guaranteed that the state on the shadow node will be the most recent state in most cases.
This change fixes state updates being ignored when cloning YogaLayoutableShadowNodes from a commit hook. Since the most recent state gets updated post commit, any clone reading the most recent state might miss state changes done within the commit.
Changelog: [Internal]
Reviewed By: rshest, cipolleschi
Differential Revision: D72315898